Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection object leaks the password #93

Closed
evangelos-dimitriadis opened this issue Aug 25, 2021 · 1 comment
Closed

Connection object leaks the password #93

evangelos-dimitriadis opened this issue Aug 25, 2021 · 1 comment
Assignees
@gijzelaerr
Milestone
1.6.0

Comments

@evangelos-dimitriadis
Copy link

The connection object has a mapi object, which has a password field. The password is plain text.
I was wondering if there is a way to hide that field.

Psycopg for example doesn't return the password, but probably if someone inspects the memory of the program they could find it:
https://www.psycopg.org/docs/connection.html?highlight=password
@gijzelaerr
Copy link
Collaborator

gijzelaerr commented Mar 3, 2022 •
edited
Loading

i guess we could replace the self.passwords and just pass it as an argument during init in mapi.py.

gijzelaerr added a commit that referenced this issue Apr 12, 2022
@gijzelaerr
fix issue #93
f032a5a
@gijzelaerr gijzelaerr added this to the 1.6.0 milestone Apr 12, 2022
@gijzelaerr gijzelaerr self-assigned this Apr 12, 2022
gijzelaerr added a commit that referenced this issue Apr 13, 2022
@gijzelaerr @joerivanruth
Add some more checks and fix them, also don't leak password (fixes #104…
05411c0 
… and #93) (#105)

* pass default pylama checks

* fix formatting error

* just use flake8

* fix spacing

* fix more warnings

* fix issue #93

* make mypy happy

* fix doc build by slight restructure

* prepare for 1.6.0

* doc shuffle

* Document handle_download

* remove one more empty line

Co-authored-by: Joeri van Ruth <joeri.van.ruth@monetdbsolutions.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gijzelaerr gijzelaerr

Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@gijzelaerr @evangelos-dimitriadis