fix(client): ensure path params are non-empty (#343)

src/modern_treasury/resources/account_collection_flows.py

@@ -132,6 +132,8 @@ def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._get(
             f"/api/account_collection_flows/{id}",
             options=make_request_options(
@@ -171,6 +173,8 @@ def update(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._patch(
             f"/api/account_collection_flows/{id}",
             body=maybe_transform(
@@ -342,6 +346,8 @@ async def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._get(
             f"/api/account_collection_flows/{id}",
             options=make_request_options(
@@ -381,6 +387,8 @@ async def update(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._patch(
             f"/api/account_collection_flows/{id}",
             body=maybe_transform(

src/modern_treasury/resources/account_details.py

@@ -68,6 +68,10 @@ def create(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not accounts_type:
+            raise ValueError(f"Expected a non-empty value for `accounts_type` but received {accounts_type!r}")
+        if not account_id:
+            raise ValueError(f"Expected a non-empty value for `account_id` but received {account_id!r}")
         return self._post(
             f"/api/{accounts_type}/{account_id}/account_details",
             body=maybe_transform(
@@ -112,6 +116,12 @@ def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not accounts_type:
+            raise ValueError(f"Expected a non-empty value for `accounts_type` but received {accounts_type!r}")
+        if not account_id:
+            raise ValueError(f"Expected a non-empty value for `account_id` but received {account_id!r}")
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._get(
             f"/api/{accounts_type}/{account_id}/account_details/{id}",
             options=make_request_options(
@@ -146,6 +156,10 @@ def list(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not accounts_type:
+            raise ValueError(f"Expected a non-empty value for `accounts_type` but received {accounts_type!r}")
+        if not account_id:
+            raise ValueError(f"Expected a non-empty value for `account_id` but received {account_id!r}")
         return self._get_api_list(
             f"/api/{accounts_type}/{account_id}/account_details",
             page=SyncPage[AccountDetail],
@@ -193,6 +207,12 @@ def delete(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not accounts_type:
+            raise ValueError(f"Expected a non-empty value for `accounts_type` but received {accounts_type!r}")
+        if not account_id:
+            raise ValueError(f"Expected a non-empty value for `account_id` but received {account_id!r}")
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         extra_headers = {"Accept": "*/*", **(extra_headers or {})}
         return self._delete(
             f"/api/{accounts_type}/{account_id}/account_details/{id}",
@@ -251,6 +271,10 @@ async def create(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not accounts_type:
+            raise ValueError(f"Expected a non-empty value for `accounts_type` but received {accounts_type!r}")
+        if not account_id:
+            raise ValueError(f"Expected a non-empty value for `account_id` but received {account_id!r}")
         return await self._post(
             f"/api/{accounts_type}/{account_id}/account_details",
             body=maybe_transform(
@@ -295,6 +319,12 @@ async def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not accounts_type:
+            raise ValueError(f"Expected a non-empty value for `accounts_type` but received {accounts_type!r}")
+        if not account_id:
+            raise ValueError(f"Expected a non-empty value for `account_id` but received {account_id!r}")
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._get(
             f"/api/{accounts_type}/{account_id}/account_details/{id}",
             options=make_request_options(
@@ -329,6 +359,10 @@ def list(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not accounts_type:
+            raise ValueError(f"Expected a non-empty value for `accounts_type` but received {accounts_type!r}")
+        if not account_id:
+            raise ValueError(f"Expected a non-empty value for `account_id` but received {account_id!r}")
         return self._get_api_list(
             f"/api/{accounts_type}/{account_id}/account_details",
             page=AsyncPage[AccountDetail],
@@ -376,6 +410,12 @@ async def delete(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not accounts_type:
+            raise ValueError(f"Expected a non-empty value for `accounts_type` but received {accounts_type!r}")
+        if not account_id:
+            raise ValueError(f"Expected a non-empty value for `account_id` but received {account_id!r}")
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         extra_headers = {"Accept": "*/*", **(extra_headers or {})}
         return await self._delete(
             f"/api/{accounts_type}/{account_id}/account_details/{id}",

src/modern_treasury/resources/bulk_requests.py

@@ -115,6 +115,8 @@ def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._get(
             f"/api/bulk_requests/{id}",
             options=make_request_options(
@@ -277,6 +279,8 @@ async def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._get(
             f"/api/bulk_requests/{id}",
             options=make_request_options(

src/modern_treasury/resources/bulk_results.py

@@ -55,6 +55,8 @@ def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._get(
             f"/api/bulk_results/{id}",
             options=make_request_options(
@@ -163,6 +165,8 @@ async def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._get(
             f"/api/bulk_results/{id}",
             options=make_request_options(

src/modern_treasury/resources/counterparties.py

@@ -143,6 +143,8 @@ def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._get(
             f"/api/counterparties/{id}",
             options=make_request_options(
@@ -194,6 +196,8 @@ def update(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._patch(
             f"/api/counterparties/{id}",
             body=maybe_transform(
@@ -309,6 +313,8 @@ def delete(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         extra_headers = {"Accept": "*/*", **(extra_headers or {})}
         return self._delete(
             f"/api/counterparties/{id}",
@@ -403,6 +409,8 @@ def collect_account(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._post(
             f"/api/counterparties/{id}/collect_account",
             body=maybe_transform(
@@ -536,6 +544,8 @@ async def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._get(
             f"/api/counterparties/{id}",
             options=make_request_options(
@@ -587,6 +597,8 @@ async def update(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._patch(
             f"/api/counterparties/{id}",
             body=maybe_transform(
@@ -702,6 +714,8 @@ async def delete(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         extra_headers = {"Accept": "*/*", **(extra_headers or {})}
         return await self._delete(
             f"/api/counterparties/{id}",
@@ -796,6 +810,8 @@ async def collect_account(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._post(
             f"/api/counterparties/{id}/collect_account",
             body=maybe_transform(

src/modern_treasury/resources/documents.py

@@ -92,7 +92,6 @@ def create(
             # sent to the server will contain a `boundary` parameter, e.g.
             # multipart/form-data; boundary=---abc--
             extra_headers = {"Content-Type": "multipart/form-data", **(extra_headers or {})}
-
         return self._post(
             "/api/documents",
             body=maybe_transform(body, document_create_params.DocumentCreateParams),
@@ -130,6 +129,8 @@ def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._get(
             f"/api/documents/{id}",
             options=make_request_options(
@@ -275,7 +276,6 @@ async def create(
             # sent to the server will contain a `boundary` parameter, e.g.
             # multipart/form-data; boundary=---abc--
             extra_headers = {"Content-Type": "multipart/form-data", **(extra_headers or {})}
-
         return await self._post(
             "/api/documents",
             body=maybe_transform(body, document_create_params.DocumentCreateParams),
@@ -313,6 +313,8 @@ async def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._get(
             f"/api/documents/{id}",
             options=make_request_options(

src/modern_treasury/resources/events.py

@@ -55,6 +55,8 @@ def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._get(
             f"/api/events/{id}",
             options=make_request_options(
@@ -153,6 +155,8 @@ async def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._get(
             f"/api/events/{id}",
             options=make_request_options(

src/modern_treasury/resources/expected_payments.py

@@ -195,6 +195,8 @@ def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._get(
             f"/api/expected_payments/{id}",
             options=make_request_options(
@@ -287,6 +289,8 @@ def update(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._patch(
             f"/api/expected_payments/{id}",
             body=maybe_transform(
@@ -456,6 +460,8 @@ def delete(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return self._delete(
             f"/api/expected_payments/{id}",
             options=make_request_options(
@@ -633,6 +639,8 @@ async def retrieve(
 
           timeout: Override the client-level default timeout for this request, in seconds
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._get(
             f"/api/expected_payments/{id}",
             options=make_request_options(
@@ -725,6 +733,8 @@ async def update(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._patch(
             f"/api/expected_payments/{id}",
             body=maybe_transform(
@@ -894,6 +904,8 @@ async def delete(
 
           idempotency_key: Specify a custom idempotency key for this request
         """
+        if not id:
+            raise ValueError(f"Expected a non-empty value for `id` but received {id!r}")
         return await self._delete(
             f"/api/expected_payments/{id}",
             options=make_request_options(