Notice invalid_input_files_in_subfolder not triggered if zip file and subfolder have the same name

[praneethd7]

Describe the bug

As the title says. Currently, the notice invalid_input_files_in_subfolder is not triggered when the zip file (without .zip) and the sub folder have the same name.

Possible Reason:
The condition is not satisfied here and the notice is not raised

gtfs-validator/core/src/main/java/org/mobilitydata/gtfsvalidator/input/GtfsInput.java

Line 111 in 665cbc6

if (containsSubfolder && entryName.contains(subfolder) && entryName.endsWith(".txt")) {

Steps/Code to Reproduce

Example Case [has subfolder piercetransit-wa-us--flex-v2]:
piercetransit-wa-us_zip.zip - Will raise the notice
piercetransit-wa-us--flex-v2.zip - Does not raise the notice

Expected Results

Actual Results

Screenshots

No response

Files used

No response

Validator version

6.0.0

Operating system

Windows

Java version

No response

Additional notes

No response

[sylvansson]

Hi @praneethd7, I looked into this and I think the filename was a red herring. I shared some findings in #1972. Were both of your ZIP files created the same way?

[praneethd7]

@sylvansson Thank you for taking a crack at this. Looked through the PR and it LGTM. Could you elaborate on what you mean by " Were both of your ZIP files created the same way?"

[sylvansson]

I'm just curious as to whether they were created using the same command or tool. Apparently the ZIP file specification doesn't explicitly require or disallow entries for folders, there's a great explanation here.

[sylvansson]

@qcdyx I see you just picked this up. I just want to make sure you know I already have a PR (#1972) for this :-)

[qcdyx]

@sylvansson Got it!

[praneethd7]

@sylvansson, I have not used any command to create these zip files. I used the Compress to feature on my Windows machine. I hope that answers your question.

[sylvansson]

It's interesting that they would be structured differently then. Good to know, thank you :-)