-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-7542] - add validation for hwm_column parameter #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-lixakov
added
the
ci:skip-changelog
Add this label to skip changelog file check
label
Jul 19, 2023
dolfinus
reviewed
Jul 19, 2023
dolfinus
reviewed
Jul 19, 2023
dolfinus
reviewed
Jul 19, 2023
tests/tests_unit/test_db/test_db_reader_unit/test_kafka_reader_unit.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #78 +/- ##
===========================================
- Coverage 92.72% 92.69% -0.03%
===========================================
Files 139 140 +1
Lines 6131 6162 +31
Branches 1123 1132 +9
===========================================
+ Hits 5685 5712 +27
- Misses 345 347 +2
- Partials 101 103 +2
|
dolfinus
reviewed
Jul 19, 2023
tests/tests_unit/test_db/test_db_reader_unit/test_kafka_reader_unit.py
Outdated
Show resolved
Hide resolved
tests/tests_unit/test_db/test_db_reader_unit/test_kafka_reader_unit.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Maxim Martynov <msmarty5@mts.ru>
dolfinus
reviewed
Jul 20, 2023
dolfinus
approved these changes
Jul 20, 2023
andy-takker
approved these changes
Jul 20, 2023
Comment on lines
398
to
+402
values["hwm_column"] = Column(name=hwm_column) # type: ignore | ||
values["hwm_expression"] = hwm_expression | ||
|
||
dialect = connection.Dialect | ||
dialect.validate_hwm_column(connection, hwm_column) # type: ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
values["hwm_column"] = Column(name=hwm_column) # type: ignore | |
values["hwm_expression"] = hwm_expression | |
dialect = connection.Dialect | |
dialect.validate_hwm_column(connection, hwm_column) # type: ignore | |
dialect = connection.Dialect | |
dialect.validate_hwm_column(connection, hwm_column) # type: ignore | |
values["hwm_column"] = Column(name=hwm_column) # type: ignore | |
values["hwm_expression"] = hwm_expression |
я бы сделал так, а то странно проводить валидацию после присвоения в values
dmitry-pedchenko
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
validate_hwm_column
method for abstractclass Dialect
and its implementation inKafka.Dialect
validate_hwm_column
inKafka.Dialect
classRelated issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)