-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-2349] - Add ReadOptions, WriteOptions for Kafka connection #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
reviewed
Jul 13, 2023
dolfinus
reviewed
Jul 13, 2023
dolfinus
reviewed
Jul 13, 2023
dolfinus
reviewed
Jul 13, 2023
Codecov Report
@@ Coverage Diff @@
## develop #68 +/- ##
===========================================
+ Coverage 93.16% 93.18% +0.01%
===========================================
Files 129 130 +1
Lines 6146 6163 +17
Branches 1149 1149
===========================================
+ Hits 5726 5743 +17
Misses 322 322
Partials 98 98
|
Co-authored-by: Maxim Martynov <msmarty5@mts.ru>
Co-authored-by: Maxim Martynov <msmarty5@mts.ru>
dolfinus
reviewed
Jul 13, 2023
dolfinus
reviewed
Jul 13, 2023
dolfinus
approved these changes
Jul 13, 2023
andy-takker
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
ReadOptions
&WriteOptions
for Kafka connectionRelated issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)