Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOP-2349] - Add ReadOptions, WriteOptions for Kafka connection #68

Merged
merged 6 commits into from
Jul 13, 2023
Merged

[DOP-2349] - Add ReadOptions, WriteOptions for Kafka connection #68

merged 6 commits into from
Jul 13, 2023

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Jul 13, 2023 •
edited
Loading

Change Summary

  • Added ReadOptions & WriteOptions for Kafka connection
  • Added unit tests for validating read & write options

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #68 (af89203) into develop (f4affb6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #68      +/-   ##
===========================================
+ Coverage    93.16%   93.18%   +0.01%     
===========================================
  Files          129      130       +1     
  Lines         6146     6163      +17     
  Branches      1149     1149              
===========================================
+ Hits          5726     5743      +17     
  Misses         322      322              
  Partials        98       98
Impacted Files Coverage Δ
onetl/connection/db_connection/kafka/connection.py 91.48% <100.00%> (+0.28%) ⬆️
onetl/connection/db_connection/kafka/options.py 100.00% <100.00%> (ø)

@maxim-lixakov @dolfinus
Update onetl/connection/db_connection/kafka/connection.py
89c3539 
Co-authored-by: Maxim Martynov <msmarty5@mts.ru>
@maxim-lixakov @dolfinus
Update onetl/connection/db_connection/kafka/connection.py
1b25879 
Co-authored-by: Maxim Martynov <msmarty5@mts.ru>
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi July 13, 2023 08:16 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi July 13, 2023 09:34 — with GitHub Actions Inactive
@dolfinus dolfinus marked this pull request as ready for review July 13, 2023 09:56
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi July 13, 2023 10:58 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi July 13, 2023 11:29 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov merged commit 8e060bc into develop Jul 13, 2023
29 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-2349 branch July 13, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfinus dolfinus dolfinus approved these changes

@andy-takker andy-takker andy-takker approved these changes

@dmitry-pedchenko dmitry-pedchenko Awaiting requested review from dmitry-pedchenko

Assignees

@maxim-lixakov maxim-lixakov

Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxim-lixakov @dolfinus @andy-takker