-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-6701] Add SparkLocalFS connection #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 09:57
a5a78c4
to
eef0ca5
Compare
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 10:32
eef0ca5
to
1c03ecd
Compare
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 10:41
1c03ecd
to
2999d29
Compare
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 10:53
2999d29
to
d91a3e6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #67 +/- ##
===========================================
- Coverage 93.15% 92.82% -0.33%
===========================================
Files 133 135 +2
Lines 6209 6317 +108
Branches 1156 1172 +16
===========================================
+ Hits 5784 5864 +80
- Misses 327 350 +23
- Partials 98 103 +5
|
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 11:55
d91a3e6
to
54c4472
Compare
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 12:55
54c4472
to
8cb43d1
Compare
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 13:04
8cb43d1
to
aed8d2d
Compare
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 13:08
aed8d2d
to
c300096
Compare
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 13:13
c300096
to
ae643bc
Compare
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 13:17
ae643bc
to
e288c95
Compare
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 13:24
e288c95
to
70acdd9
Compare
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 12, 2023 13:34
70acdd9
to
cea9b67
Compare
dolfinus
removed
the
ci:skip-changelog
Add this label to skip changelog file check
label
Jul 12, 2023
dolfinus
force-pushed
the
feature/DOP-6701
branch
from
July 13, 2023 15:04
cea9b67
to
13f3bbe
Compare
dmitry-pedchenko
approved these changes
Jul 14, 2023
andy-takker
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
SparkLocalFS
class and related tests, docs and CI jobdb_connection
andfile_connection
to subfolders of newconnection
folder, added herefile_df_connection
subfolder.SparkFileDFConnection._check_if_supported
I've found thatGreenplum
/MongoDB._check_if_driver_imported
were called inread_source
/write_target
methods, but they are useless because this check is already done in.check()
method. Removed these calls.Currently there are no integration tests for reading & writing files because there are no file formats implemented. They will be added in future pull requests.
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)