Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-23742] Fix using conn.setReadOnly(...) for MySQL, MSSQL #337

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 6, 2025

Change Summary

Some JDBC drivers respect java_jdbc_connection.setReadOnly(...) (Oracle, Clickhouse, Postgres, Greenplum), some don't (MySQL, MSSQL). Fixing this by adding few workarounds for these RDBMS.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Feb 6, 2025
@dolfinus dolfinus force-pushed the bugfix/DOP-23742-mssql-mysql branch from 6d9907c to 73dcefa Compare February 6, 2025 08:22
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (64550d1) to head (73dcefa).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #337      +/-   ##
===========================================
+ Coverage    91.84%   91.88%   +0.04%     
===========================================
  Files          228      228              
  Lines         9821     9836      +15     
  Branches      1007     1008       +1     
===========================================
+ Hits          9020     9038      +18     
+ Misses         606      605       -1     
+ Partials       195      193       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review February 6, 2025 08:34
@dolfinus dolfinus merged commit fef4ecc into develop Feb 6, 2025
41 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-23742-mssql-mysql branch February 6, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants