Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-23743] All hardcoded passwords in this repo are used ONLY for tests #335

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 5, 2025

Change Summary

This is to shut up security scanners or information security guys which think we are storing here some production passwords. No, they are used just for tests, and nothing more.

Also fixed several small issues with tests, like Clickhouse client haven't used database/user/password at all, password wasn't quoted in SQLAlchemy URLs used by Pandas, and so on.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Feb 5, 2025
@dolfinus dolfinus self-assigned this Feb 5, 2025
@dolfinus dolfinus force-pushed the improvement/DOP-22427 branch from 282f692 to 4d6ab7a Compare February 5, 2025 09:55
@dolfinus dolfinus force-pushed the improvement/DOP-22427 branch from 4d6ab7a to 0bd96a7 Compare February 5, 2025 10:00
@dolfinus dolfinus force-pushed the improvement/DOP-22427 branch from 0bd96a7 to 4d26485 Compare February 5, 2025 11:03
@dolfinus dolfinus force-pushed the improvement/DOP-22427 branch from 4d26485 to 579c1a0 Compare February 5, 2025 11:19
@dolfinus dolfinus changed the title [DOP-22427] Use test_only! value as password for all servers [DOP-22427] All hardcoded passwords in this repo are used ONLY for tests Feb 5, 2025
@dolfinus dolfinus force-pushed the improvement/DOP-22427 branch from 579c1a0 to 34045a5 Compare February 5, 2025 11:26
@dolfinus dolfinus force-pushed the improvement/DOP-22427 branch from 34045a5 to 8463171 Compare February 5, 2025 12:11
@dolfinus dolfinus force-pushed the improvement/DOP-22427 branch from 8463171 to f0b2e6c Compare February 5, 2025 12:22
@dolfinus dolfinus force-pushed the improvement/DOP-22427 branch from f0b2e6c to 78185cb Compare February 5, 2025 12:49
@dolfinus dolfinus marked this pull request as ready for review February 5, 2025 13:00
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (78bf9f6) to head (78185cb).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #335      +/-   ##
===========================================
+ Coverage    91.69%   92.00%   +0.30%     
===========================================
  Files          228      228              
  Lines         9842     9842              
  Branches      1009     1009              
===========================================
+ Hits          9025     9055      +30     
+ Misses         621      598      -23     
+ Partials       196      189       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus changed the title [DOP-22427] All hardcoded passwords in this repo are used ONLY for tests [DOP-23743] All hardcoded passwords in this repo are used ONLY for tests Feb 5, 2025
@dolfinus dolfinus merged commit 0bc6eac into develop Feb 5, 2025
52 checks passed
@dolfinus dolfinus deleted the improvement/DOP-22427 branch February 5, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants