-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-23743] All hardcoded passwords in this repo are used ONLY for tests #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
282f692
to
4d6ab7a
Compare
4d6ab7a
to
0bd96a7
Compare
0bd96a7
to
4d26485
Compare
4d26485
to
579c1a0
Compare
579c1a0
to
34045a5
Compare
34045a5
to
8463171
Compare
8463171
to
f0b2e6c
Compare
f0b2e6c
to
78185cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #335 +/- ##
===========================================
+ Coverage 91.69% 92.00% +0.30%
===========================================
Files 228 228
Lines 9842 9842
Branches 1009 1009
===========================================
+ Hits 9025 9055 +30
+ Misses 621 598 -23
+ Partials 196 189 -7 ☔ View full report in Codecov by Sentry. |
IlyasDevelopment
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This is to shut up security scanners or information security guys which think we are storing here some production passwords. No, they are used just for tests, and nothing more.
Also fixed several small issues with tests, like Clickhouse client haven't used database/user/password at all, password wasn't quoted in SQLAlchemy URLs used by Pandas, and so on.
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)