Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-14063] Drop onetl._internal module #290

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Jun 4, 2024

Change Summary

Move functions from onetl._internal module to submodules of onetl._util. This module is not a part of public interface, so this is not a breaking change, and there is no item in the changelog.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Jun 4, 2024
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (f50f008) to head (85c792a).
Report is 58 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #290      +/-   ##
===========================================
+ Coverage    94.87%   94.88%   +0.01%     
===========================================
  Files          210      210              
  Lines         8207     8188      -19     
  Branches      1413     1410       -3     
===========================================
- Hits          7786     7769      -17     
+ Misses         298      297       -1     
+ Partials       123      122       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review June 4, 2024 12:56
@dolfinus dolfinus merged commit a015b80 into develop Jun 4, 2024
46 checks passed
@dolfinus dolfinus deleted the feature/DOP-14063 branch June 4, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants