Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-15764] - add jdbc option classes #277

Merged
merged 6 commits into from
May 22, 2024
Merged

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented May 21, 2024

Change Summary

  • Add ReadOptions, WriteOptions, SQLOptions, FetchOptions, ExecuteOptions option classes for each JDBC connector.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus
Copy link
Member

В unit тестах, где проверяются всякие snake_case -> camelCase, prohibited options и т.п., нужно в pytest.mark.parametrize перечислить все добавленные классы

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.79%. Comparing base (e9788fd) to head (86b6534).
Report is 71 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #277      +/-   ##
===========================================
+ Coverage    94.71%   94.79%   +0.07%     
===========================================
  Files          204      210       +6     
  Lines         8068     8187     +119     
  Branches      1410     1410              
===========================================
+ Hits          7642     7761     +119     
  Misses         304      304              
  Partials       122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-lixakov maxim-lixakov added the ci:skip-changelog Add this label to skip changelog file check label May 22, 2024
@maxim-lixakov maxim-lixakov merged commit 1f73652 into develop May 22, 2024
40 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-15764 branch May 22, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants