Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13252] Improve Oracle documentation #233

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Mar 11, 2024

Change Summary

  • Added separated page with Oracle <-> Spark types mapping, and recommendations related to type casts.
  • Added separated page with Oracle prerequisites like port number and grants.
  • Split documentation of DBReader and Oracle.sql to different pages
  • Added more examples to reading & writing data to Oracle, and using fetch and execute methods.
  • Also updated a bit documentation of other DB connections, like Clickhouse, Greenplum, Postgres, to provide unified document structure.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (f306a97) to head (27a5f25).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #233   +/-   ##
========================================
  Coverage    94.39%   94.39%           
========================================
  Files          204      204           
  Lines         7880     7880           
  Branches      1401     1401           
========================================
  Hits          7438     7438           
  Misses         317      317           
  Partials       125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review March 11, 2024 15:26
@dolfinus dolfinus merged commit 02ba65a into develop Mar 12, 2024
37 checks passed
@dolfinus dolfinus deleted the feature/DOP-13252 branch March 12, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants