Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-9645] - Add XML file format #163

Merged
merged 15 commits into from
Oct 10, 2023
Merged

[DOP-9645] - Add XML file format #163

merged 15 commits into from
Oct 10, 2023

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Oct 5, 2023

Change Summary

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 6, 2023 08:56 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov self-assigned this Oct 6, 2023
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 6, 2023 09:07 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov marked this pull request as ready for review October 6, 2023 09:15
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #163 (52d600f) into develop (32c37ed) will increase coverage by 0.01%.
The diff coverage is 96.07%.

@@             Coverage Diff             @@
##           develop     #163      +/-   ##
===========================================
+ Coverage    94.33%   94.34%   +0.01%     
===========================================
  Files          209      210       +1     
  Lines         7925     7976      +51     
  Branches      1490     1500      +10     
===========================================
+ Hits          7476     7525      +49     
- Misses         326      327       +1     
- Partials       123      124       +1     
Files Coverage Δ
onetl/file/format/__init__.py 100.00% <100.00%> (ø)
onetl/file/format/xml.py 96.00% <96.00%> (ø)

onetl/file/format/xml.py Outdated Show resolved Hide resolved
onetl/file/format/xml.py Outdated Show resolved Hide resolved
onetl/file/format/xml.py Outdated Show resolved Hide resolved
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 6, 2023 11:38 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 6, 2023 12:46 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 6, 2023 12:55 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 6, 2023 13:14 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 6, 2023 14:21 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 9, 2023 07:06 — with GitHub Actions Inactive
onetl/file/format/xml.py Outdated Show resolved Hide resolved
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 9, 2023 09:20 — with GitHub Actions Inactive
onetl/file/format/xml.py Outdated Show resolved Hide resolved
Co-authored-by: Maxim Martynov <msmarty5@mts.ru>
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 9, 2023 10:30 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to test-pypi October 9, 2023 10:32 Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 9, 2023 10:42 — with GitHub Actions Inactive
@dolfinus dolfinus merged commit edcc141 into develop Oct 10, 2023
35 checks passed
@dolfinus dolfinus deleted the feature/DOP-9645 branch October 10, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants