Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-8665] - Allow modes "ignore" and "error" in JDBC.WriteOptions #144

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Sep 7, 2023

Change Summary

  • add ignore and error modes (if_exists=...) to JDBC.WriteOptions
  • add unit and integration tests
  • updated documentation

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #144 (e0b4242) into develop (5d4b4b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #144   +/-   ##
========================================
  Coverage    94.27%   94.27%           
========================================
  Files          207      207           
  Lines         7701     7703    +2     
  Branches      1449     1449           
========================================
+ Hits          7260     7262    +2     
  Misses         321      321           
  Partials       120      120           
Files Changed Coverage Δ
...ection/db_connection/jdbc_connection/connection.py 100.00% <100.00%> (ø)
...onnection/db_connection/jdbc_connection/options.py 100.00% <100.00%> (ø)

📢 Have feedback on the report? Share it here.

@maxim-lixakov maxim-lixakov self-assigned this Sep 7, 2023
@maxim-lixakov maxim-lixakov marked this pull request as ready for review September 7, 2023 13:36
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi September 8, 2023 15:20 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov merged commit 0adf055 into develop Sep 11, 2023
30 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-8665 branch September 11, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants