Remap indexstore contents in parallel #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongjincho92
force-pushed
the
yongjin/index-import/update-indexstore-in-parallel
branch
3 times, most recently
from
22542db
to
ca4f373
Compare
yongjincho92
changed the title
brentleyjones
approved these changes
Jun 16, 2023
|
What was your end result improvement here? Also what's the issue with running this when you have more than 1 index store? |
|
You'll need to fix the DCO here too. Lgtm tho |
Tested locally with a single indexstore that has 51K index unit files.
I was afraid to break that scenario, but I could try locally with multiple input indexstore as well and enable this for that scenario as well. |
|
that's a huge win! I hope there's some more low hanging fruit like this too. |
yongjincho92
changed the title
Signed-off-by: Yongjin Cho <ycho@snapchat.com>
yongjincho92
force-pushed
the
yongjin/index-import/update-indexstore-in-parallel
branch
from
812babb
to
f7c7815
Compare
keith
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For a single indexstore that contains ~50k unit files, it can take ~25 minutes to just run index-import on.
Changes
If single indexstore is processed, process indexstore content in parallel
Tests
Tested locally with a single indexstore that has 51K index unit files.