Allow not having a records directory #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's valid to not have records (i.e. an empty swift file), and Bazel won't create empty directories when downloading from a remote cache. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/allow-not-having-a-records-directory
branch
from
bb0fd99
to
987a428
Compare
|
hrm, i imagine more often than not this is an actual error? |
|
I encountered this in the wild, especially with the global indexing feature in rules_swift. Do you want it behind a flag as well? |
|
it has to be a module with no source files with content? |
|
Yes. A couple people have encountered this. We need a way to allow this, either with a flag or warning (preferably with a flag). |
keith
reviewed
Sep 7, 2022
keith
approved these changes
Sep 7, 2022
|
Can definitely happen in large projects assuming you don't lint for these things 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's valid to not have records (i.e. an empty swift file), and Bazel won't create empty directories when downloading from a remote cache.