Write invalid remapped paths to unit files #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
FileManager::getFile()
, if the path does not exist, then the unit file will contain a blank path for that field. UsinggetVirtualFile()
will ensure that even invalid paths are written into the unit file. Invalid paths are useful for two reasons:index-import
(viaabsolute-unit
)In the second case, it's better to see an invalid path than an empty path.
The solution should be to use
getVirtualFile()
everywhere, but this function asserts if called with an empty path (which can legitimately happen[1]). The final solution is to callgetVirtualFile
in all cases except for the empty string which requiresgetFile
..pcm
files have an emptyMainFilePath