Remap source/target paths for includes #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastiglione
reviewed
Sep 19, 2019
| @@ -173,9 +173,12 @@ static IndexUnitWriter remapUnit(const std::unique_ptr<IndexUnitReader> &reader, | |||
| }); | |||
|
|
|||
| reader->foreachInclude([&](const IndexUnitReader::IncludeInfo &info) { | |||
| // Note this isn't revelevnt to Swift. | |||
There was a problem hiding this comment.
revelevn't – obviously
kastiglione
reviewed
Sep 19, 2019
kastiglione
reviewed
Sep 19, 2019
kastiglione
reviewed
Sep 19, 2019
|
I guess I can commit the suggestions myself… |
|
Scratch that, I don't have permission to commit the suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the remappings to the source/target paths for each
#includeas well. This is relevant to C/C++/ObjC sources and not Swift.The goal of this change was to allow Xcode to correctly resolve
#includestatements from a remapped index that originated from Bazel. This change doesn't fully fix that but is part of the solution.