-
Notifications
You must be signed in to change notification settings - Fork 249
Boilerplate: add favicon #207
Comments
react-helmet has been documented in 2665fc7 |
Do you think we should add a generic favicon?! Note sure it's a good idea, but at the same time it seems legit. But if we do so, we should add sort of apple-touch stuff? Should we? |
Good point. But I think we should add phenomic's favicon. No need for a generic one. It's easier for new user to replace it :) .
👍 In fact, this is a full list of apple-touch icons. https://github.com/VinSpee/vinspee.me/blob/master/web_modules/LayoutContainer/index.js |
The implementation should be straight forward. You can use this commit as your guide c7bd549 |
I don't think it's "that" simple. I want to ship a best practice. So we should include favicons/ios/android/edge icons. So maybe use http://realfavicongenerator.net/ engine (I think there is siomething in node, we could even make a loader or a simple script to automate this). |
Started to look into this issue. Found https://github.com/jantimon/favicons-webpack-plugin |
@dab feel free to take a look to https://realfavicongenerator.net/ node api (see link in the footer, upload a random image and grab the code) |
Going to be fixed with #925 |
v1 will have a "public" folder feature. |
No description provided.
The text was updated successfully, but these errors were encountered: