Boilerplate: add favicon

[MoOx]

No description provided.

[MoOx]

react-helmet has been documented in 2665fc7

[MoOx]

Do you think we should add a generic favicon?! Note sure it's a good idea, but at the same time it seems legit. But if we do so, we should add sort of apple-touch stuff? Should we?

[thangngoc89]

Good point. But I think we should add phenomic's favicon. No need for a generic one. It's easier for new user to replace it :) .

we should add sort of apple-touch stuff

👍

In fact, this is a full list of apple-touch icons. https://github.com/VinSpee/vinspee.me/blob/master/web_modules/LayoutContainer/index.js

[thangngoc89]

The implementation should be straight forward. You can use this commit as your guide c7bd549

[MoOx]

I don't think it's "that" simple. I want to ship a best practice. So we should include favicons/ios/android/edge icons. So maybe use http://realfavicongenerator.net/ engine (I think there is siomething in node, we could even make a loader or a simple script to automate this).

[dab]

Started to look into this issue. Found https://github.com/jantimon/favicons-webpack-plugin
It's working fine, but slow down build process a lot. Will check for other node-based solutions. Also it can be good idea to check if icons already exists, so no need to regenerate it each time.
The other question here — how to inject links markup to our html. It can be done manually, if we will use some predefined and constant name for it, or we can use some generative approach?

[MoOx]

@dab feel free to take a look to https://realfavicongenerator.net/ node api (see link in the footer, upload a random image and grab the code)

[bloodyowl]

Going to be fixed with #925

[MoOx]

v1 will have a "public" folder feature.