Cleanup build #26
Merged
Cleanup build #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes here, just a few housekeeping things: 1) Renamed it to "build.yml" and "Buildroot" since it's responsibilities have now expanded. 2) Got rid of all the caching stuff since we're not using it any more. 3) Updated the upload-artifact action to v3 to resolve the warnings Github was logging about v2 using a deprecated node.js version
tiopex
requested changes
Mar 29, 2023
tiopex
approved these changes
Mar 29, 2023
|
I think we should let the build finish before merging, just to make sure I didn't break anything... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes here, just a few housekeeping things:
Renamed it to "build.yml" and "Buildroot" since it's responsibilities have now expanded.
Got rid of all the image caching stuff that we're not using it any more. (Edit: but keep the ccache part.)
Updated the upload-artifact action to v3 to resolve the warnings Github was logging about v2 using a deprecated node.js version