Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: closure compiler requires HTTPS now #2007

Merged
merged 1 commit into from
Oct 29, 2017
Merged

fix: closure compiler requires HTTPS now #2007

merged 1 commit into from
Oct 29, 2017

Conversation

tivac
Copy link
Contributor

@tivac tivac commented Oct 29, 2017

Description

Closure compiler endpoint was returning a 302 since we were using HTTP and it now requires HTTPS. So now using the https module instead of the http module for communication.

Motivation and Context

Fixes #2005

How Has This Been Tested?

npm run minify

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@tivac
fix: closure compiler requires HTTPS now
96e93e9 
Also barfing out the response from the server when JSON parsing errors happen
@tivac tivac added the Area: Workflow For anything dealing with Mithril's internal tooling, including the mocks and bundler, but not ospec label Oct 29, 2017
@tivac tivac requested a review from lhorie as a code owner October 29, 2017 05:51
@dead-claudia dead-claudia removed the request for review from lhorie October 29, 2017 05:52
@Gandalf-the-Bot
Copy link
Contributor

Warnings
⚠️

Please add an entry to docs/change-log.md.

Generated by 🚫 dangerJS

@tivac tivac merged commit efb0e94 into MithrilJS:next Oct 29, 2017
@tivac tivac deleted the fixing-minify branch October 29, 2017 05:57
tivac added a commit to tivac/mithril.js that referenced this pull request Nov 28, 2017
@tivac
fix: closure compiler requires HTTPS now (MithrilJS#2007)
d27cb4b 
Also barfing out the response from the server when JSON parsing errors happen
pygy pushed a commit that referenced this pull request Nov 29, 2017
@tivac @pygy
fix: closure compiler requires HTTPS now (#2007)
460725d 
Also barfing out the response from the server when JSON parsing errors happen
@dead-claudia
Copy link
Member

Added the backport label so we can still release correctly on v1_1_x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-claudia dead-claudia dead-claudia approved these changes

Assignees
No one assigned
Labels
Area: Workflow For anything dealing with Mithril's internal tooling, including the mocks and bundler, but not ospec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Builds are breaking because of an invalid JSON response from the Closure Compiler API
3 participants
@tivac @Gandalf-the-Bot @dead-claudia