-
-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream updated after conditionaly halt its parent #1714
Labels
Type: Bug
For bugs and any other unexpected breakage
Comments
I'd say that's definitely odd... |
It looks weird to me as well, but I'm not very familiar with the stream code either... |
A little trick to get around this bug is to update without using the dependent stream returned by the mapping. var halt = true;
var child = stream('c');
parent.map(function(p) {
child(halt ? stream.HALT : p);
}); |
porsager
added a commit
to porsager/mithril.js
that referenced
this issue
Aug 8, 2018
11 tasks
porsager
added a commit
to porsager/mithril.js
that referenced
this issue
Aug 9, 2018
* Fix MithrilJS#1714 conditionally halting stream * Add note in changelog
dead-claudia
pushed a commit
that referenced
this issue
Nov 14, 2018
…2194) * output mithril, stream and ospec esm versions on build * Add esm bundles * [request] Clearer error message for JSON deserialization failure (#2195) * Bundled output for commit fd7cf80 [skip ci] * Fix #1714 conditionally halting stream (#2200) * Fix #1714 conditionally halting stream * Add note in changelog * Do not include stream as named export in mithril.esm.js * Rename mithril.min.esm.js to mithril.esm.min.js * Add esm files to eslintignore * Add named exports * Add hyperscript `m` as named export * Add builds with export changes * checkout regular bundled files * Change .esm.js to .mjs * Update pkg module to point to .mjs * Fix for export names to avoid collision * Updated bundled files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I encounter an unexpected behavior when I use Mithril streams, here is the JSFiddle. I expect that
count
equals zero whenhalt
istrue
. I also try to replace themap
with acombine
but the result is the same.I also write a test, that will become a pull request if it's really an issue or a misunderstanding.
Gaspar.
The text was updated successfully, but these errors were encountered: