Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation of the model #16

Open
3 tasks
rs028 opened this issue Apr 11, 2019 · 1 comment
Open
3 tasks

Compilation of the model #16

rs028 opened this issue Apr 11, 2019 · 1 comment
Labels
code revision Improve source code (replace outdated code, improve legibility...) decision A decision is needed to progress question Further information is requested structure Issues related to folder structure or structure of the source code upgrade Upgrade source code, shell scripts, plotting scripts
Milestone
Mistra v9.0

Comments

@rs028
Copy link
Collaborator

rs028 commented Apr 11, 2019 •
edited
Loading

  • the mistra executable should maybe sit in the main directory rather than in src/, or in a separate bin/ directory.
  • are 2 Makefiles (and hence two compilation steps) really needed? There is one Makefile in the src/ directory and one in the src/mech/ directory.
  • does it make more sense for the mech/ directory to be moved out of src/ and into the main directory?
@rs028 rs028 added upgrade Upgrade source code, shell scripts, plotting scripts question Further information is requested code revision Improve source code (replace outdated code, improve legibility...) decision A decision is needed to progress structure Issues related to folder structure or structure of the source code labels Apr 11, 2019
@rs028 rs028 added this to the Mistra v9.0 milestone Apr 11, 2019
rs028 pushed a commit that referenced this issue Jul 29, 2022
@JosueBock
Merge pull request #16 from JosueBock/master
a4947ba 
Cosmetic improvements, mostly in file str.f90
@rs028 rs028 mentioned this issue Aug 3, 2022
Closed
@rs028
Copy link
Collaborator Author

rs028 commented Aug 24, 2022

Related to this point: the Makefiles may need to be modified by the user. Add them to .gitignore?

@rs028 rs028 added upgrade Upgrade source code, shell scripts, plotting scripts and removed upgrade Upgrade source code, shell scripts, plotting scripts labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code revision Improve source code (replace outdated code, improve legibility...) decision A decision is needed to progress question Further information is requested structure Issues related to folder structure or structure of the source code upgrade Upgrade source code, shell scripts, plotting scripts
Projects
None yet
Milestone
Mistra v9.0
Development

No branches or pull requests
1 participant
@rs028