Make network_type optional

[atsaki]

This patch allows to omit network_type when Basic network is used.

network_type is only used to determine which option is used network_ids or security_group_ids.
It can be determine whether variables are nil or not.

[coveralls]

Coverage remained the same at 84.58% when pulling ea2bb10 on atsaki:optional_network_type into dfdf83a on schubergphilis:master.

[miguelaferreira]

Hi @atsaki
I'm in the process of getting a virtualised cloudstack environment (i.e. cloudstack in cloudstack) and that will enable me to test against Basic networking zones. However, as of now I can only test against advanced networking zones. In order to get this PR in the release I'm preparing I will merge it without testing it myself. Later, I will come back to this.

BTW, manual testing is a drag and I've been exploring possibilities for having automated functional tests. I've seen something called vagrantspec but that seems rather immature. So I'm planning to just add a directory to the repo, and in there multiple subdirectories (one per test case). Then each test case would be a vagranfile that exercises a particular use scenario.
Please let me know if you have ideas/thoughts on this, I would very much appreciate it.

Cheers

[atsaki]

Hi @miguelaferreira

Thank you for merging.

BTW, manual testing is a drag and I've been exploring possibilities for having automated functional tests.

I completely agree with you. Although I haven't tested yet, I think CloudStack simulator and travis can be one option to have automated tests like https://travis-ci.org/apache/cloudstack. It may be used to use test scenarios defined by vagrantfiles

[miguelaferreira]

I also heard that from colleagues working on cloudstack. It seems there are some jenkins builds that run against the simulator, and we should definitely explore that.
(The simulator build is somewhere here, I think: http://jenkins.buildacloud.org)

Meanwhile, I'm working on a set of bats tests that simulate what we have been testing manually. These tests do need a cloudstack instance with at least two zones deployed (with Basic and Advanced networking) to run against.
The first draft is here: https://github.com/miguelaferreira/vagrant-cloudstack/tree/functional-tests-with-bats/functional-tests

I'll investigate the possibility of having a publicly available cloudstack environment to test against, but feel free to investigate the simulator angle, it would be great if we could get that up and running.