Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DaemonSet version to apps/v1 #701

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Change DaemonSet version to apps/v1 #701

merged 1 commit into from
Jun 25, 2018

Conversation

lukaszo
Copy link
Contributor

@lukaszo lukaszo commented Jun 25, 2018 •
edited by pigmej
Loading

It has enabled RollingUpdate by default

This change is Reviewable

@jellonek
Copy link
Contributor

:lgtm:

Reviewed 3 of 3 files at r1.
Review status: 0 of 2 LGTMs obtained, and 1 stale

Comments from Reviewable

@lukaszo
Change DaemonSet version to apps/v1
47778fc 
It has enabled RollingUpdate by default
@ivan4th
Copy link
Contributor

ivan4th commented Jun 25, 2018

:lgtm:

Reviewed 3 of 3 files at r1, 5 of 5 files at r2.
Review status: 0 of 2 LGTMs obtained, and 2 stale

Comments from Reviewable

@jellonek
Copy link
Contributor

:lgtm:

Reviewed 5 of 5 files at r2.
Review status: 1 of 2 LGTMs obtained, and 1 stale

Comments from Reviewable

@jellonek jellonek merged commit 3e75fe9 into master Jun 25, 2018
@jellonek jellonek deleted the ds-update branch June 25, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszo @jellonek @ivan4th