Bump docker client to 20.10 and use StatsOneShot to get stats #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This returns stats nearly instantly instead of having to wait for > 1s. This feature was added in the 20.10 daemon. When connecting to older daemons the stats will behave just as before since. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
@cpuguy83 next expected build is in ~2 weeks unless there's a critical issue this is blocking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See moby/moby#40478 for details on the newer stats option.
This significantly speeds up container stats collection.