Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOPY-1670: change shutil move for copy #632

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

MatthieuCMira
Copy link
Contributor

@MatthieuCMira MatthieuCMira commented Oct 7, 2024

GEOPY-1670 - cannot finalize workspace if tmp folder is not on the destination disk
created a function, but I cannot create a unitest on it.

Guess the back and forth of testing will be there...

@github-actions github-actions bot changed the title change shutil move for copy GEOPY-1670: change shutil move for copy Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.67%. Comparing base (cfe3b1b) to head (9c7bf31).
Report is 4 commits behind head on release/0.10.0.

Files with missing lines Patch % Lines
geoh5py/workspace/workspace.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/0.10.0     #632   +/-   ##
===============================================
  Coverage           90.67%   90.67%           
===============================================
  Files                 104      104           
  Lines                8671     8671           
  Branches             1772     1772           
===============================================
  Hits                 7862     7862           
  Misses                434      434           
  Partials              375      375           
Files with missing lines Coverage Δ
geoh5py/shared/utils.py 90.12% <100.00%> (ø)
geoh5py/ui_json/utils.py 88.81% <100.00%> (ø)
geoh5py/workspace/workspace.py 90.09% <33.33%> (ø)

Copy link
Contributor

@sebhmg sebhmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code should still do a move when it can. Please see suggestions

geoh5py/shared/utils.py Outdated Show resolved Hide resolved
geoh5py/ui_json/utils.py Outdated Show resolved Hide resolved
geoh5py/workspace/workspace.py Outdated Show resolved Hide resolved
geoh5py/workspace/workspace.py Outdated Show resolved Hide resolved
@sebhmg sebhmg merged commit f598da6 into release/0.10.0 Oct 8, 2024
13 checks passed
@sebhmg sebhmg deleted the GEOPY-1670 branch October 8, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants