GEOPY-1669: Final clean up of Object class

[MatthieuCMira]

GEOPY-1669 - Final clean up of Object class
I changed the object base a bit.

I added some comments "#todo: ..." within the code.
Can you comment back and then, and I'll correct/remove them if needed

[codeclimate]

The PR diff size of 11677 lines exceeds the maximum allowed for the inline comments feature.

[codeclimate]

Analysis results are not available for those commits

View more on Code Climate.

[MatthieuCMira]

Other general questions:
I have the feeling the "object" is not being updated to the workspace in the functions.
Is this normal?

[MatthieuCMira]

I have the feeling the changes made on an ObjectBase are never saved to GA.

if self.on_file: self.workspace.update_attribute(self,

is this normal?

[MatthieuCMira]

Should we remove faces property?
I understand it can be implemented in the future, but for now, it's used nowhere

[codecov]

Codecov Report

Attention: Patch coverage is 97.36842% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.65%. Comparing base (21baa0d) to head (8122b78).
Report is 11 commits behind head on release/0.10.0.

Files with missing lines	Patch %	Lines
geoh5py/objects/object_base.py	96.77%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##           release/0.10.0     #625      +/-   ##
==================================================
+ Coverage           90.47%   90.65%   +0.18%     
==================================================
  Files                 104      104              
  Lines                8693     8672      -21     
  Branches             1773     1772       -1     
==================================================
- Hits                 7865     7862       -3     
+ Misses                445      434      -11     
+ Partials              383      376       -7     

Files with missing lines	Coverage Δ
geoh5py/data/numeric_data.py	95.65% <ø> (ø)
geoh5py/groups/property_group.py	97.56% <100.00%> (ø)
geoh5py/groups/property_group_table.py	98.00% <100.00%> (ø)
geoh5py/objects/cell_object.py	93.39% <100.00%> (+2.24%)	⬆️
geoh5py/objects/notype_object.py	91.66% <ø> (+3.43%)	⬆️
geoh5py/objects/points.py	89.85% <100.00%> (-0.43%)	⬇️
geoh5py/objects/surveys/electromagnetics/tipper.py	93.90% <100.00%> (ø)
geoh5py/shared/concatenation/concatenator.py	90.90% <100.00%> (+0.02%)	⬆️
geoh5py/shared/concatenation/drillhole.py	87.91% <100.00%> (ø)
geoh5py/shared/merging/base.py	96.82% <100.00%> (ø)
... and 5 more

[domfournier]

Getting there. Few more sticky points.