Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deployable #50

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Update deployable #50

merged 3 commits into from
Oct 12, 2021

Conversation

bdfinst
Copy link
Collaborator

@bdfinst bdfinst commented Oct 12, 2021

Add Dave Farley's suggestion that the pipeline is the final arbiter of deployable.

Jerreck
Jerreck approved these changes Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@Jerreck Jerreck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we were just thinking this implicitly, so this is definitely worth stating explicitly. Approved.

@bdfinst bdfinst changed the title Update deployable WIP: Update deployable Oct 12, 2021
@bdfinst bdfinst changed the title WIP: Update deployable Update deployable Oct 12, 2021
@bdfinst bdfinst mentioned this pull request Oct 12, 2021
Closed
ibathazi
ibathazi approved these changes Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@ibathazi ibathazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. Looks good.

@bdfinst bdfinst merged commit 9adf16b into master Oct 12, 2021
@ibathazi ibathazi deleted the update-deployable branch October 17, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jerreck Jerreck Jerreck approved these changes

@ibathazi ibathazi ibathazi approved these changes

@davef77 davef77 davef77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdfinst @davef77 @ibathazi @Jerreck