Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Work in Small Batches #367

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Edit Work in Small Batches #367

merged 1 commit into from
Mar 7, 2024

Conversation

golubitsky
Copy link
Contributor

Description

A few minor edits to improve readability in the article.

@golubitsky golubitsky requested a review from a team as a code owner February 26, 2024 17:22
Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for minimumcd ready!

Name Link
🔨 Latest commit ca2b882
🔍 Latest deploy log https://app.netlify.com/sites/minimumcd/deploys/65dcc8ca3f4cf7000802a85c
😎 Deploy Preview https://deploy-preview-367--minimumcd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70
Accessibility: 82
Best Practices: 92
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@golubitsky
Copy link
Contributor Author

golubitsky commented Feb 26, 2024

There is an "ERROR render of "section" failed" error in the hugo command of the Run npm test step. There appear to be several upstream "execute of template failed" errors. I assume these errors are not related to the change in this PR (only to a single Markdown file). I am not familiar with Hugo, but I might take a look later today.

The CI failure linked above uses Hugo version: 0.123.3.

The last successful build used Hugo version: 0.122.0.

Update on 2024-03-06

I'm able to reproduce these build errors locally.

Steps to reproduce

Env info

Commit is current origin/master HEAD:

$ git log -1 --pretty=oneline
f4f50a79a80a1b5ea90dea4419151edd89718737 (HEAD -> master, origin/master, origin/HEAD) Signature 'Emanuele Filannino' (#366)
$ hugo env
hugo v0.123.7-312735366b20d64bd61bff8627f593749f86c964+extended darwin/amd64 BuildDate=2024-03-01T16:16:06Z VendorInfo=brew
GOOS="darwin"
GOARCH="amd64"
GOVERSION="go1.22.0"
github.com/sass/libsass="3.6.5"
github.com/webmproject/libwebp="v1.3.2"
$ npm run build

> minimumcd@1.0.0 build
> hugo

Start building sites …
hugo v0.123.7-312735366b20d64bd61bff8627f593749f86c964+extended darwin/amd64 BuildDate=2024-03-01T16:16:06Z VendorInfo=brew

ERROR render of "section" failed: "/Users/mgolubitsky/source/cd-manifesto/themes/docport/layouts/_default/baseof.html:71:11": execute of template failed: template: _default/section.html:71:11: executing "_default/section.html" at <partial "body-header.html" .>: error calling partial: execute of template failed: template: partials/body-header.html:10:8: executing "partials/body-header.html" at <partial "_mdinclude.html" (dict "name" "header" "context" . "tip" $defaultheader)>: error calling partial: "/Users/mgolubitsky/source/cd-manifesto/themes/docport/layouts/partials/_mdinclude.html:6:10": execute of template failed: template: partials/_mdinclude.html:6:10: executing "siteBlock" at <where .page.Site.Pages "File.BaseFileName" $path>: error calling where: runtime error: invalid memory address or nil pointer dereference
Total in 122 ms
Error: error building site: render: failed to render pages: render of "section" failed: "/Users/mgolubitsky/source/cd-manifesto/themes/docport/layouts/_default/baseof.html:71:11": execute of template failed: template: _default/section.html:71:11: executing "_default/section.html" – Pages "File is nil; wrap it in if or with: {{ with partial "body-header.html" .>: error calling partial: execute of template failed: template: partials/body-header.html:10:8: executing "partials/body-header.html" at <partial "_mdinclude.html" (dict "name" "header" "context" . "tip" )>: error calling partial: "/Users/mgolubitsky/source/cd-manifesto/themes/docport/layouts/partials/_mdinclude.html:6:10": execute of template failed: template: partials/_mdinclude.html:6:10: executing "siteBlock" at <where .page.Site.Pages "File }}{{ .where }}{{ end }}

@bdfinst bdfinst merged commit 7e62fa5 into Minimum-CD:master Mar 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants