-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to docusaurus #324
Conversation
✅ Deploy Preview for minimumcd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun fact, I'm in the middle of converting my company's docs site from Docusaurus to Hugo to eliminate the vulnerabilities in React.
What do you see as the advantage to this large a change?
hello @bdfinst thanks for the comment, I opened a discussion in #323. From my perspective, here are my thoughts:
Toward your concerns, React is a very active project many companies depend on, it will probably be taken care of sooner than later, and actually, we will get Dependabot to notify us abut those vulnerabilities. |
|
The base tradeoff of generic static code generators like Hugo/Jekyll/Hexo/... is that the driving factor of the site is not the site itself, but the theme behind it. While It's true, it's possible to create short codes, those short codes are just HTML snipped that are resolved at compile time with small support for JS (no real complexity is allowed). I have worked and migrated from Docsy before, Personally my opinion is more than changing a few configurations there is not too much control over the content of the page, specially the landing or any intermediate page you want to create navigation for. For example, to actually do some real modifications, you had to fork and create your own theme. Answering your question about dynamic content missing in minimal CD, if we were in docusaurus/astro/... we could, for example, use a library like react flow to generate dynamic content showing how TBD works that will be engaging similar to this kafka visualization from softwaremill. With this in mind, we can push collaborations of the bigger community if we use a mainstream language that allows development by anyone without a new learning curve. If we stick to Hugo, the issue is that community and that knowledge is more siloed & complex. We need to take in count that the end goal of this group is to create engagement in the community to push forward CD if we can create more dinamic and engagement materia with things like react flow & also grow the capability for others to create easier the engagement material is a win win. Getting back to the main point of this PR docusaurus helps us:
|
This seems like a huge lift for a hypothetical PR for an animated TBD workflow. Do you have one you're wanting to add? If someone wants to flex their artistic muscles, this would be a lot less code and would align with the minimalism we get so many compliments on. |
@bdfinst I have given a few more reasons, it is up to you and the rest of the group to decide if this makes sense. The resume of why I think this is as good move are:
Again, this is not about flexing artistically or hypotheticals. It's about using a technology that has stagnated for the last 2 years with a small community (Hugo) vs another that still growing and has large adoption (React). At the end, both compile markdowns into HTML, but one is more flexible and extensible than the other. Overall, this PR is about community engagement and capabilities to become part of the group and collaborate. |
I've used Docusaurus, Gatsby, Jekyll, and Hugo quite a bit. "No need to modify a template to later modify the content." "Docusaurus uses mainstream technology." "It improves the capability for people to contribute." "Extensive documentation" "Extensive ecosystem" "Frequent updates and security patches."
This is what I get on the current site
It's also significantly faster to build the current site locally. I'm in the process of replacing Docusaurus with Hugo at work so I'm feeling the pain of the build time difference there. "Docusaurus is better maintained than any of the templates of generic systems." "Docusaurus has a great integration for search with algolia that enables our users to get better access to our documentation." There are a couple of significant problems with this PR.
The structure of the main page has been optimized to ensure that any changes to the core content that people are signing on that they agree with have easily verifiable changes. That's why the signature, contributor, and other additional content on the main page are generated from other resources rather than simply part of the main page. This PR destroys that traceability. I understand you prefer React, but the fact that there are many React developers is not a huge deal for goals of this project. I've talked to the rest of the team and they are also a bit confused about the value. We do appreciate the enthusiasm and would love help with the content, but we don't think this particular PR is in the best interests of the project goals. |
If those are your thoughts we are not going to get anywhere, and i dont feel this is my place to cooperate when there is 0 reflection and all is being defensive. |
Get more experience with open-source contributions. Go convert Docusaurus to Angular and see what they say. ;) Also, since we are maintaining the site, changes that make that experience objectively worse don't help. |
Hugo is a dev dependency, so there are no CVEs. This is an apples-to-apples comparison. To reiterate:
Collaboration doesn't consist of trying to bully people into accepting your PR. |
Description
minimumcd.webm
Fixes #323