Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: add new compat entry for CrystallographyCore at version 0.1, (keep existing compat) #91

Conversation

github-actions[bot]
Copy link
Contributor

This pull request sets the compat entry for the CrystallographyCore package to 0.1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@singularitti singularitti force-pushed the compathelper/new_version/2023-08-14-00-06-58-102-02620047895 branch from b1646bc to 0926d2c Compare August 14, 2023 00:07
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 37.77% and project coverage change: +4.79% 🎉

Comparison is base (aad84a1) 57.87% compared to head (869aaa1) 62.67%.
Report is 57 commits behind head on main.

❗ Current head 869aaa1 differs from pull request most recent head 0926d2c. Consider uploading reports for the commit 0926d2c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   57.87%   62.67%   +4.79%     
==========================================
  Files           8        9       +1     
  Lines         273      217      -56     
==========================================
- Hits          158      136      -22     
+ Misses        115       81      -34     
Files Changed Coverage Δ
src/CrystallographyBase.jl 100.00% <ø> (ø)
src/cell.jl 94.73% <ø> (+29.82%) ⬆️
src/metric.jl 76.00% <ø> (ø)
src/show.jl 0.00% <0.00%> (ø)
src/volume.jl 27.27% <ø> (ø)
src/lattice.jl 69.73% <35.29%> (+9.93%) ⬆️
src/transform.jl 57.57% <83.33%> (+11.23%) ⬆️
src/reciprocal.jl 83.33% <100.00%> (+20.83%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@singularitti singularitti merged commit 0d6dcc2 into main Aug 15, 2023
@singularitti singularitti deleted the compathelper/new_version/2023-08-14-00-06-58-102-02620047895 branch August 15, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant