Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript Error Tracking #138

Merged
merged 28 commits into from
Jan 15, 2019
Merged

Javascript Error Tracking #138

merged 28 commits into from
Jan 15, 2019

Conversation

UberMouse
Copy link
Contributor

@UberMouse UberMouse commented Jan 15, 2019

This adds the js_api_key configuration option, if it's present it'll inject the JS code to a HTML page.

Some key changes:

  • I moved the folder specs to spec to be more inline with other projects I've worked on.
  • I added a dummy app for full integration tests
  • I changed the RSpec syntax to use expect( something ).to eq( something else ) as it's closer to their sample docs.
  • I upgraded a few of the gems to be the latest.
  • I added SimpleCov to track coverage of RSpec

This is for the issue #132

This is a continuation of @MikeRogers0 work in #134


This change is Reviewable

MikeRogers0 and others added 28 commits September 3, 2018 21:56
@UberMouse UberMouse merged commit 44a4d42 into master Jan 15, 2019
@UberMouse UberMouse deleted the feature/js-error-tracking branch January 15, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants