Introduce exception raygun_custom_data instance method #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! This is a good use case to support and lines up with features available in other language providers e.g Raygun4JS, so we'll definitely be including this in some form. There's a couple of additional considerations to handle other scenarios including the ability to accept a Proc etc, but I'll be getting one of the team to review this further next week for you. We'll be in touch again shortly. |
|
Pretty happy with this as is so I'm merging it. I'll be adding a proc to allow a global hook for custom data as per #28 as well. |
|
@UberMouse Awesome! Any idea how long til a gem release includes this? |
|
I'll release v1.3 most likely sometime on Monday (GMT+12) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the case:
I want to raise an exception and have my Rack middleware(s) handle it. However, I also want to include custom data to raygun.
AFAICT this case was not supported, so here we are. Open to feedback. Thanks!