dup hashes before applying whitelist filter to them

MindscapeHQ · Mar 9, 2017 · 6ed5f9a · 6ed5f9a
1 parent c3fb0a0
commit 6ed5f9a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 1.2.1 (09/03/2017)
+
+Bugfixes:
+  - dup input hashes before applying whitelist filtering, previously this was modifying the contents of `action_dispatch.request.parameters`
+
 ## 1.2.0 (09/03/2017)
 
 Features:

diff --git a/lib/raygun/services/apply_whitelist_filter_to_payload.rb b/lib/raygun/services/apply_whitelist_filter_to_payload.rb
@@ -8,13 +8,17 @@ def call(whitelist, payload)
       private
 
       def filter_hash(whitelist, hash)
+        # dup the input so each level of the hash is dup'd
+        # not just the top as dup isn't deep
+        hash = hash.dup
+
         hash.each do |k, v|
           unless whitelist && (whitelist[k] || whitelist[k.to_sym])
             hash[k] = '[FILTERED]'
           end
 
           if v.is_a?(Hash) && whitelist[k].is_a?(Hash)
-            filter_hash(whitelist[k], v)
+            hash[k] = filter_hash(whitelist[k], v)
           end
         end
       end