Filter out __RestrictedErrorObjectReference #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phillip-haydon Thought I'd open this for discussion first. Any thoughts on this approach to solving the linked issue? I'll bump the version later once we're agreed on a solution. |
phillip-haydon
deleted the
Filter-out-__RestrictedErrorObjectReference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #547
WinRT exceptions can have a value in the Exception.Data dictionary with a key of "__RestrictedErrorObjectReference" and a value of type WinRT.ObjectReferenceWithContext<WinRT.Interop.IUnknownVftbl>. When trying to serialize this value, a System.AccessViolationException is thrown which can crash the application, even if caught.
This PR is a candidate fix for this issue which take the approach of recognizing the Data dictionary key and not including the value in the report sent to Raygun.