Prevent exception from being thrown and then immediately caught when getting debug information #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProRedCat
previously approved these changes
Sep 11, 2024
phillip-haydon
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
. .
_..-''"""\ _.--'"""\
| L | \
_ / _.-.---.\. / .-.----.\
_/-|--- _/<"---'"""""\\`. /-'--''"""""\
| \ | L`.`-. | L
/_.-.---.L | \ \ `| J`.
_/--'"""" \ F \L \ | L
L `. L J _.---.-"""-.\`. L_/ _.--|"""""--.\ `.
| \+. /-"__.--'"""" \ `./'"---'"""""" \`. `.
F _____ \ `F" `. \ \ L `.
/.-'"_|---'"\ | ` JL | L `.`.
<-'"" \| _.-.------._ A J _.-.-----`.--| ``.`.
L `. |/.-'"_.-`---'""\."| /-'"---'""""" \`.\. \ `.`.
| _.------\.<'""" L\ L\ `.`\`. \ `.
_.-'//'"--'""" L\| ________\ `.F ___.-------._L \ `-\ \`.
/___| F F _.--'"_|-------L /_.-'"_.-|-'"""""""\ L L `.`.
| F _.-'|"""""/'"-'""" J <'""" L J | `.`.
|/-'-''/|""\ )-|\ F \ | L .'"""`\""-\\_
F`-'-'-(`-') | \ F \ |___`"""`.""`.-'"
------------/ `-'---| F L L __ |"""""`-'"__________
.'_ | |__L __ J__ | _.--'"""" `".----'".'
'""""""""""""|--._+--F _.-'""||" """___/.-'" ||-'"/""""" \_. .'
J------------(___\__/'_____.--------'-------'"""""""" /
`-. _.__.__.__.____ J_.-._
.'`-._ (-`--`---.'--._`---._.-'`-._.-'_.-'``-._' `-''-'
JasenPalmer
deleted the
jp/prevent-exception-getting-debug-information
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to prevent an exception from being thrown and then immediately caught within the
TryGetDebugInformationmethod.Its possible that in certain circumstances, a stack frame originates from a module that only exists in memory. In this situation, the name of the module will not be a locaiton on disk so loading that module from disk will fail. This causes the
PEReaderto be null.