Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Singleton RaygunClient in RaygunHttpModule (.NET Framework) #537

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Use Singleton RaygunClient in RaygunHttpModule (.NET Framework) #537

merged 7 commits into from
Jul 25, 2024

Conversation

MattByers
Copy link
Contributor

@MattByers MattByers commented Jul 19, 2024 •
edited
Loading

Description

Update the RaygunHttpModule for ASP.NET Framework applications to store and use a single RaygunClient instance. This avoids a new RaygunClient and in turn a ThrottledBackgroundMessageProcessor, from being created for every exception handled by the RaygunHttpModule. The ThrottledBackgroundMessageProcessor creates a number of background worker threads, so instantiating it for each exception can be costly.

QuantumNightmare
QuantumNightmare reviewed Jul 21, 2024
View reviewed changes
Copy link
Contributor

@QuantumNightmare QuantumNightmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a couple of thoughts to discuss

Mindscape.Raygun4Net4/RaygunHttpModule.cs Outdated Show resolved Hide resolved
Mindscape.Raygun4Net4/RaygunHttpModule.cs Show resolved Hide resolved
QuantumNightmare
QuantumNightmare previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@QuantumNightmare QuantumNightmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Looks good, just comment on one optional minor thing that I didn't think of before.

Mindscape.Raygun4Net4/RaygunHttpModule.cs Outdated Show resolved Hide resolved
QuantumNightmare
QuantumNightmare previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@QuantumNightmare QuantumNightmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@MattByers
Retrieve context id before request message, so that the ASP.NET_Sessi…
f350e0b 
…onId cookie is present when request message is built.
QuantumNightmare
QuantumNightmare approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@QuantumNightmare QuantumNightmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MattByers MattByers merged commit c1ed837 into master Jul 25, 2024
1 check passed
@MattByers MattByers deleted the mb/singleton-client-asp-net-framework-http-module branch July 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumNightmare QuantumNightmare QuantumNightmare approved these changes

@phillip-haydon phillip-haydon Awaiting requested review from phillip-haydon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattByers @phillip-haydon @QuantumNightmare