Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Icons, license, and .Net versions supported #462

Merged
merged 4 commits into from
Feb 28, 2022
Merged

Conversation

darcythomas
Copy link
Contributor

No description provided.

Copy link
Contributor

@QuantumNightmare QuantumNightmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just added one question for my understanding. Also, we didn't want to use a colored icon? (A colored icon appears on the NuGet site, but this monochromatic one appears in Visual Studio. Can barely see it when using the VS dark theme).

<PackageReference Include="Microsoft.AspNetCore.Http" Version="2.2.2" />
<PackageReference Include="Microsoft.AspNetCore.Http.Extensions" Version="2.2.0" />
<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="1.1.2" />
<PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="2.2.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why this dependency was added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I mis-read this. https://docs.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0#when-to-target-net50-or-net60-vs-netstandard.

Re reading I guess targeting 2.0 and .net5-6 would be best

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, should be fine to target 2.1, was just wondering why the Abstractions package was also added. Perhaps the IDE added this for you.

@darcythomas
Copy link
Contributor Author

darcythomas commented Feb 24, 2022

Looks good, just added one question for my understanding. Also, we didn't want to use a colored icon? (A colored icon appears on the NuGet site, but this monochromatic one appears in Visual Studio. Can barely see it when using the VS dark theme).

@QuantumNightmare
I just took the icon which was in the iconlink, downloaded and added that.

Do you know where I would find the colored one?

@QuantumNightmare
Copy link
Contributor

Not sure where the colored one in the NuGet site is coming from. Just thinking while you're in this space, could optionally confirm with a designer which icon we want to use.

@darcythomas
Copy link
Contributor Author

Updated Icon (correct color) and removed un-need package imports

Copy link
Contributor

@QuantumNightmare QuantumNightmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 👍

@darcythomas
Copy link
Contributor Author

Tested against targets:

.NET and .NET Core 1.0, 1.1, 2.0, 2.1, 2.2, 3.0, 3.1, 5.0, 6.0
.NET Framework  4.6.1 2, 4.6.2, 4.7, 4.7.1, 4.7.2, 4.8

@darcythomas darcythomas merged commit b9ee903 into master Feb 28, 2022
@darcythomas darcythomas deleted the darcy/APL-188 branch February 28, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants