Merge pull request #531 from MindscapeHQ/sean/portable-pdb-extensions

Add fully quality module name and remove the android handled
MindscapeHQ · May 27, 2024 · 6678ade · 6678ade
2 parents cd3a86c + b7306e3
commit 6678ade
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/Mindscape.Raygun4Net.Core/Builders/RaygunErrorMessageBuilder.cs b/Mindscape.Raygun4Net.Core/Builders/RaygunErrorMessageBuilder.cs
@@ -139,7 +139,7 @@ public static RaygunErrorStackTraceLineMessage[] BuildStackTrace(StackTrace stac
             methodName = GenerateMethodName(method);
             className = method.ReflectedType != null ? method.ReflectedType.FullName : "(unknown)";
             ilOffset = frame.GetILOffset();
-            debugInfo = TryGetDebugInformation(method.Module.Name);
+            debugInfo = TryGetDebugInformation(method.Module.FullyQualifiedName);
 
             // This might fail in medium trust environments or for array methods,
             // so don't crash the entire send process - just move on with what we have

diff --git a/Mindscape.Raygun4Net.NetCore.Common/Builders/RaygunErrorMessageBuilder.cs b/Mindscape.Raygun4Net.NetCore.Common/Builders/RaygunErrorMessageBuilder.cs
@@ -80,7 +80,7 @@ public static RaygunErrorStackTraceLineMessage[] BuildStackTrace(StackTrace stac
             methodName = GenerateMethodName(method);
             className = method.ReflectedType != null ? method.ReflectedType.FullName : "(unknown)";
             ilOffset = frame.GetILOffset();
-            debugInfo = TryGetDebugInformation(method.Module.Name);
+            debugInfo = TryGetDebugInformation(method.Module.FullyQualifiedName);
 
             // This might fail in medium trust environments or for array methods,
             // so don't crash the entire send process - just move on with what we have

diff --git a/Mindscape.Raygun4Net.NetCore.Common/Platforms/AndroidPlatform.cs b/Mindscape.Raygun4Net.NetCore.Common/Platforms/AndroidPlatform.cs
@@ -49,7 +49,6 @@ private static void AndroidUnhandledExceptionHandler(object sender, object excep
       {
         var exceptionArgsType = exceptionArgs.GetType();
         exception = (Exception)exceptionArgsType.GetProperty("Exception").GetValue(exceptionArgs);
-        exceptionArgsType.GetProperty("Handled")?.SetValue(exceptionArgs, true);
       }
       catch (Exception ex)
       {