Do not recompute hashes on ledger commit #15979
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: recomputation of hashes is costly and is absolutely nonsensical when we commit child ledger to parent.
Solution: provide hashes map from child to parent to be used in operation of hash recomputation for the accounts being added.
This change improved performance of transaction application for 9-account-update transactions by ~20% (as measured by #14582).
Explain how you tested your changes:
Checklist: