Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] Do comparison in ocaml instead of dump the result and then run diff on it #15480

Merged
merged 19 commits into from
Apr 8, 2024
Merged

[develop] Do comparison in ocaml instead of dump the result and then run diff on it #15480

merged 19 commits into from
Apr 8, 2024

Conversation

ghost-not-in-the-shell
Copy link
Contributor

Explain your changes:
fix merge conflict in #15479

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@ghost-not-in-the-shell ghost-not-in-the-shell requested review from a team as code owners April 6, 2024 22:19
@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

1 similar comment
@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@ghost-not-in-the-shell
Copy link
Contributor Author

!ci-build-me

@mrmr1993 mrmr1993 merged commit 6ea26a4 into develop Apr 8, 2024
41 checks passed
@mrmr1993 mrmr1993 deleted the fix/dump-db-without-superuser-develop branch April 8, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkijania dkijania dkijania approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghost-not-in-the-shell @mrmr1993 @dkijania @deepthiskumar