Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Merkle_ledger #15141

Merged
merged 31 commits into from
Feb 27, 2024
Merged

Refactoring Merkle_ledger #15141

merged 31 commits into from
Feb 27, 2024

Conversation

rbonichon
Copy link
Contributor

@rbonichon rbonichon commented Feb 16, 2024 •
edited
Loading

  • activate warnings (and fix them)
  • move interface definitions in Intf only (and thus avoid repetition)
  • add interfaces to all modules
  • remove some dead code (thanks to warnings too)

This is preliminary work/scaffolding for heavier changes (to come at some point down the road)

Still todo

  • Cleanup history (do not review until this is crossed)

@rbonichon rbonichon self-assigned this Feb 16, 2024
@rbonichon rbonichon changed the title Refactorg Merkle_ledger Refactor Merkle_ledger Feb 16, 2024
@rbonichon rbonichon changed the title Refactor Merkle_ledger Refactoring Merkle_ledger Feb 20, 2024
@rbonichon rbonichon force-pushed the rb/merkle_ledger_intf branch from 063fcba to 90fd003 Compare February 23, 2024 15:57
@rbonichon rbonichon marked this pull request as ready for review February 23, 2024 15:57
@rbonichon rbonichon requested a review from a team as a code owner February 23, 2024 15:57
@rbonichon
Copy link
Contributor Author

!ci-build-me

@rbonichon rbonichon changed the base branch from develop to rocksdb/fold_functions February 23, 2024 16:10
@rbonichon rbonichon force-pushed the rocksdb/fold_functions branch from 88851c2 to a8e7dc8 Compare February 23, 2024 17:05
@rbonichon rbonichon force-pushed the rb/merkle_ledger_intf branch from 90fd003 to 0cec6b5 Compare February 23, 2024 17:13
@rbonichon rbonichon force-pushed the rocksdb/fold_functions branch from a8e7dc8 to e69a9ae Compare February 23, 2024 17:18
@rbonichon rbonichon force-pushed the rocksdb/fold_functions branch 2 times, most recently from 863d859 to 86469aa Compare February 23, 2024 21:09
@rbonichon
Merkle_ledger: simplify functions
e327e18
@rbonichon
Merkle_ledger: interface for Util
efd8125
@rbonichon
Merkle_ledger: interface for Location
7c97163
@rbonichon
Merkle_ledger: remove unused equal function
69116d8
@rbonichon
Merkle_ledger: remove unused Merkle_path_intf module
967626f
@rbonichon
Merkle_ledger: actual interface for Merkle_path
5dd4c11
@rbonichon
Merkle_ledger: rm unused check_path in Merkle_path
0529763
@rbonichon
Merkle_ledger: interface for Null_ledger
dd18e9d
@rbonichon
Merkle_ledger: interface for Database
e2ef0ce
@rbonichon
Merkle_ledger: remove unused *_intf module
77a8178 
`Merkle_ledger_intf` and `Ledger_extras_intf` were never used
@rbonichon
Merkle_ledger: interface for Any_ledger
e97f1c1
@rbonichon
Merkle_ledger: interface for Graphviz
ead1a25
@rbonichon
Merkle_ledger: make Database_intf a pure interface
c32f5a7
@rbonichon
Merkle_ledger: minimizing module type declaration for database
7fe1a32
@rbonichon
Merkle_ledger: activate warnings
34f5973
@rbonichon rbonichon force-pushed the rb/merkle_ledger_intf branch from 0cec6b5 to da8931a Compare February 23, 2024 21:48
@emberian emberian self-requested a review February 24, 2024 14:19
Base automatically changed from rocksdb/fold_functions to develop February 25, 2024 18:16
@rbonichon
Copy link
Contributor Author

!ci-build-me

@rbonichon
Copy link
Contributor Author

!ci-build-me

@rbonichon rbonichon force-pushed the rb/merkle_ledger_intf branch from 8bd09f0 to 8377269 Compare February 26, 2024 20:43
@rbonichon
Copy link
Contributor Author

!ci-build-me

@rbonichon rbonichon merged commit e035129 into develop Feb 27, 2024
41 checks passed
@rbonichon rbonichon deleted the rb/merkle_ledger_intf branch February 27, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@emberian emberian Awaiting requested review from emberian

Assignees

@rbonichon rbonichon

Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbonichon @mrmr1993