Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bad proof systems PR #14659

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Remove bad proof systems PR #14659

merged 3 commits into from
Dec 4, 2023

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Dec 4, 2023

This PR

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 requested review from a team as code owners December 4, 2023 20:17
@mrmr1993
Copy link
Member Author

mrmr1993 commented Dec 4, 2023

!ci-build-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Dec 4, 2023

!ci-nightly-me

@dannywillems
Copy link
Member

Closing #14655 as it was fixing Pickles with the change of the reverted PR.

This was referenced Dec 4, 2023
Closed
Closed
dannywillems
dannywillems approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I'll revert the changes in snarkyjs and snarkyjs-bindings.

@dannywillems
Copy link
Member

I do confirm it solves the issue #14657

@dannywillems dannywillems mentioned this pull request Dec 4, 2023
Closed
@mrmr1993 mrmr1993 merged commit 96167da into develop Dec 4, 2023
36 of 39 checks passed
@mrmr1993 mrmr1993 deleted the feature/remove-bad-proof-systems-pr branch December 4, 2023 21:25
@dannywillems dannywillems mentioned this pull request Dec 4, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannywillems dannywillems dannywillems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @dannywillems