Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunking = fin #14344

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Chunking = fin #14344

merged 8 commits into from
Oct 18, 2023

Conversation

mrmr1993
Copy link
Member

This PR completes the work to enable chunking in pickles. Currently, this is implemented with the following constraints:

  • the same number of chunks must be used for all step rules
  • chunking is enabled by passing ~num_chunks to Pickles.compile
    • an error will be generated if this is not done, but the circuit requires chunking to support its domain size
  • the wrap circuit is unchunked, pending demand.

This PR builds upon #14331, and integrates o1-labs/proof-systems#1279 to abstract the representation of constraints over the zk rows.

This PR

  • updates the code for the introduction of zk_rows
  • tracks chunking in the tag system
  • updates the verifier to verify chunked proofs
  • updates the step circuit to accept chunked proofs
  • adds a test for chunking, with a recursion layer that hides the chunking.

@mrmr1993 mrmr1993 self-assigned this Oct 14, 2023
@mrmr1993 mrmr1993 requested review from a team as code owners October 14, 2023 19:34
@mrmr1993 mrmr1993 changed the title Feature/recursive chunks too Chunking = fin Oct 14, 2023
@mrmr1993
Copy link
Member Author

!ci-build-me

Base automatically changed from feature/and-yet-more-chunks to develop October 16, 2023 10:17
@mrmr1993 mrmr1993 changed the base branch from develop to feature/surely-not-more-chunks October 17, 2023 08:14
@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member Author

!ci-build-me

Base automatically changed from feature/surely-not-more-chunks to develop October 18, 2023 11:04
@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993 mrmr1993 merged commit 962234d into develop Oct 18, 2023
1 of 2 checks passed
@mrmr1993 mrmr1993 deleted the feature/recursive-chunks-too branch October 18, 2023 15:49
querolita
querolita reviewed Sep 9, 2024
View reviewed changes
src/lib/pickles/test/chunked_circuits/test_chunked_circuits.ml
exists Field.typ ~compute:(fun _ -> Field.Constant.zero)
in
(* Remember that each of these counts for *half* a row, so we
need 2^17 of them to fill 2^16 columns.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fill 2^16 rows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@querolita querolita querolita left review comments

@dannywillems dannywillems dannywillems approved these changes

Assignees

@mrmr1993 mrmr1993

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrmr1993 @dannywillems @querolita