Add tests for Inputs.Stack in transaction_logic/mina_transaction_logic.ml #12796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejMina226
reviewed
Mar 14, 2023
ejMina226
approved these changes
Mar 14, 2023
…com/MinaProtocol/mina into gltrost/transaction_logic_stack_tests
gltrost
changed the base branch from
develop
to
gltrost/transaction_logic_ledger_tests
gltrost
changed the base branch from
gltrost/transaction_logic_ledger_tests
to
develop
mrmr1993
approved these changes
Mar 20, 2023
rbonichon
reviewed
Mar 22, 2023
…com/MinaProtocol/mina into gltrost/transaction_logic_stack_tests
gltrost
changed the base branch from
develop
to
gltrost/transaction_logic_ledger_tests
gltrost
changed the base branch from
gltrost/transaction_logic_ledger_tests
to
develop
…com/MinaProtocol/mina into gltrost/transaction_logic_stack_tests
rbonichon
approved these changes
May 11, 2023
|
@kantp What do you think should happen to this PR? It received 3 passing reviews. |
|
Thanks @robinbb, I had lost track of this one, it seems it was blocked by CI and now got some conflicts. I'll add a task to our backlog to see if we can get it to merge. |
…n_logic_stack_tests
|
!ci-build-me |
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
Inside
transaction_logic/mina_transaction_logic.mlis a moduleInputs.Stack. This branch adds tests forInputs.Stacktotransaction_logic/tests/mina_transaction_logic.ml.Explain how you tested your changes:
I ran
dune runtest src/lib/transaction_logicto ensure all tests worked.Closes Write tests for Mina_stack module #12593 .