Print Wasm errors in JS console #11644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
requested review from
a team,
imeckler and
mrmr1993
as code owners
mrmr1993
approved these changes
Aug 9, 2022
mitschabaude
force-pushed
the
feature/wasm-rust-console
branch
from
3ca077f to
0394c4d
Compare
mitschabaude
added
the
ci-build-me
This was referenced Aug 10, 2022
mimoo
reviewed
Aug 10, 2022
| @@ -37,6 +37,8 @@ pub fn caml_pasta_fq_plonk_index_create( | |||
| prev_challenges: i32, | |||
| srs: &WasmSrs, | |||
| ) -> Result<WasmPastaFqPlonkIndex, JsValue> { | |||
| console_error_panic_hook::set_once(); | |||
There was a problem hiding this comment.
instead should we just set it in an init function as indicated here? https://github.com/rustwasm/console_error_panic_hook#usage
There was a problem hiding this comment.
yeah sorry, I didn't now how to make an init function that runs at startup, but that would be even cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses https://github.com/rustwasm/console_error_panic_hook to make Rust
paniclog messages withconsole.error, in Wasm. This makes error messages thrown in Rust much more useful. I checked that it doesn't harm prover performance