-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare configs for db and filesystem #9
Conversation
0cc6d49
to
568b7b5
Compare
568b7b5
to
4fcf86a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more generic question: how did you test your code? What results did you get?
Added unit tests for LoadEnv that loads configurations. Also tested via integration test that AWS S3 backend still works as before. |
729fa94
to
05b0e3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There are some minor issues, but nothing blocking, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good on my end!
In preparation for introducing database and filesystem storage into uptime-service-backend this pr:
database
andfilesystem
sections with related configs entries (specific fields inside will probably change, as this is mainly to introduce the mechanism for reading those multiple configs)aws_creds.json
intoapp_config.json
such that aws credentials live in theaws
section in the app_config.json