Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare configs for db and filesystem #9

Merged
merged 14 commits into from
Oct 30, 2023

Conversation

piotr-iohk
Copy link
Collaborator

In preparation for introducing database and filesystem storage into uptime-service-backend this pr:

  • introduces into app_config.json database and filesystem sections with related configs entries (specific fields inside will probably change, as this is mainly to introduce the mechanism for reading those multiple configs)
  • merges aws_creds.json into app_config.json such that aws credentials live in the aws section in the app_config.json
  • introduces unit tests for LoadEnv which loads the configs
  • updates integration tests accordingly to use new configs

@piotr-iohk piotr-iohk self-assigned this Oct 26, 2023
@piotr-iohk piotr-iohk force-pushed the prepare-configs-for-db-and-filesystem branch from 0cc6d49 to 568b7b5 Compare October 26, 2023 13:19
Copy link
Contributor

@Smorci Smorci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more generic question: how did you test your code? What results did you get?

@piotr-iohk
Copy link
Collaborator Author

A more generic question: how did you test your code? What results did you get?

Added unit tests for LoadEnv that loads configurations. Also tested via integration test that AWS S3 backend still works as before.

@piotr-iohk piotr-iohk requested a review from Smorci October 27, 2023 11:38
@piotr-iohk piotr-iohk force-pushed the prepare-configs-for-db-and-filesystem branch from 729fa94 to 05b0e3e Compare October 27, 2023 12:47
Copy link
Contributor

@Sventimir Sventimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

There are some minor issues, but nothing blocking, I think.

Copy link
Contributor

@Smorci Smorci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my end!

@piotr-iohk piotr-iohk merged commit c3b2779 into main Oct 30, 2023
@piotr-iohk piotr-iohk deleted the prepare-configs-for-db-and-filesystem branch October 30, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants