RFC 0008: Standard JavaScript Mina Wallet Provider API #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO we should also consider autodetection of wallets in this RFC. API of networks like Solana are based on https://github.com/wallet-standard/wallet-standard. This skips a lot of issues related to supply chain attack. ETH recently also released EIP addressing this issue https://eips.ethereum.org/EIPS/eip-6963. Happy to make MVP after wallet interface gets finalized. |
kantp
previously approved these changes
May 17, 2024
There was a problem hiding this comment.
Looks good to me. Thanks for all the comments and suggestions @lvshaoping007!
chad11111
previously approved these changes
May 17, 2024
halsaphi
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Introduction to the Innovation
Here is RFC-0008! It's about introducing a standard JavaScript Mina Wallet Provider API to the ecosystem.
🤔 Why This Is Important
There exists no standard way for wallets and zkApps to interact. Standardising this API means zkApps have to spend less time integrating against many wallets, allowing any wallet to interact with any zkApp.
💭 Seeking Your Input
Your expertise, feedback, and perspective are needed to ensure that all requirements for a standardised wallet provider and any implementation are met!