-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 使用 trubo & styled-component 重构 #140
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
这个改动有点大,还是保持你这边一个单独的包最好😊 |
嗯,好的~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
描述
感谢作者的贡献,这个预览组件用起来很爽~
这里我做了一些比较的改动和功能更新,可能有些东西不是所有人都喜欢,我先放这里了~
另外不知道作者是否还在维护,如果能抽出时间审核这个 pr 最好 ^_^
如果没有希望合并,我将在我的分支上继续迭代 https://github.com/big-camel/react-image-previewer ~感谢!
开发环境
nextra
依赖到最新,next
到12.3
功能更新
样式
模式选择 mode: drag | slide
启用自定义工具栏时,移除 close 图标 #130
添加
enableMouseZoom
属性overlayRender 参数中增加当前预览图片是否正在加载中
loading
在自定义工具栏时,可以根据是否正在 loading 判断禁用按钮
Bug 修复
修复只有一张图片开启loop为true的bug #141