Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all mentions of TAD to AMT #93

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Refactor all mentions of TAD to AMT #93

merged 2 commits into from
Jul 23, 2024

Conversation

laurensWe
Copy link
Member

@laurensWe laurensWe commented Jul 9, 2024 •
edited
Loading

Description

Renamed all mentions of TAD to AMT
TODO: rename the links (in the ai-validation)
TODO: rename the github project (then everybody update your origin locally)

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@laurensWe laurensWe requested a review from a team as a code owner July 9, 2024 09:38
@laurensWe laurensWe linked an issue Jul 9, 2024 that may be closed by this pull request
Rename TAD to AMT #84
Closed
@laurensWe laurensWe force-pushed the 84-rename-tad-to-amt branch 2 times, most recently from bbd58c6 to 1ff9ac1 Compare July 9, 2024 12:55
@laurensWe
Copy link
Member Author

The CI pipelines fails because I assume that we also will rename the repository and therefore the github image is still incorrect but also the sonar cloud integration

@berrydenhartog
Copy link
Member

I think you also need to regenerate the translations

berrydenhartog
berrydenhartog previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurensWe laurensWe force-pushed the 84-rename-tad-to-amt branch from 1ff9ac1 to c557cc1 Compare July 23, 2024 09:08
@laurensWe
Refactor all mentions of TAD to AMT

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c6f1409
@laurensWe laurensWe force-pushed the 84-rename-tad-to-amt branch from c557cc1 to c6f1409 Compare July 23, 2024 09:31
@laurensWe laurensWe requested a review from berrydenhartog July 23, 2024 09:35
@laurensWe
Add translations for refactoring

Verified

This commit was signed with the committer’s verified signature.
berrydenhartog Berry den Hartog
SSH Key Fingerprint: ToxSJ6fWqLwZ9k9EXTO+d2WxeSL2AaOKx7ZilA4o5SE
Verified
Learn about vigilant mode
Loading
Loading status checks…
5ea710b
berrydenhartog
berrydenhartog approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurensWe laurensWe merged commit 5ea710b into main Jul 23, 2024
11 of 12 checks passed
@laurensWe laurensWe deleted the 84-rename-tad-to-amt branch July 23, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename TAD to AMT
2 participants
@laurensWe @berrydenhartog